search

salesforce / tough-cookie

RFC6265 Cookies and CookieJar for Node.js
BSD 3-Clause "New" or "Revised" License
964 stars 207 forks source link

issue I found #441

Closed KamalUG closed 1 month ago

KamalUG commented 1 month ago

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch tough-cookie@2.5.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/tough-cookie/lib/version.js b/node_modules/tough-cookie/lib/version.js
index b34c6ae..b7127b3 100644
--- a/node_modules/tough-cookie/lib/version.js
+++ b/node_modules/tough-cookie/lib/version.js
@@ -1,2 +1,2 @@
 // generated by genversion
-module.exports = '2.5.0'
+module.exports = '4.1.4'

This issue body was partially generated by patch-package.

colincasey commented 1 month ago

@KamalUG this is just a change in the exported version number. what is the problem you're experiencing and how does this diff solve it?

I'm assuming that this version of tough-cookie in your project is 2.5.0 because it's a transitive dependency of another package like request, right? If so, maybe try solving the problem with one of the following methods to swap 2.5.0 with version 4.1.4: