The wait feature can generate names that collide with user-provided names.
(current, working as expected) An element named test with wait:true and public:truewill generate a public getter named waitForTest. This throws a compile error.
(changed, was broken) An element named test with wait:true and public:falsewill not generate a public getter named waitForTest. This should not throw an error if a user defines a method named waitForTest.
Code review notes: This is branched off the formatting PR.
QA notes: Look the JSON PO files in the PR to verify they compile as expected.
The
wait
feature can generate names that collide with user-provided names.(current, working as expected) An element named
test
withwait:true
andpublic:true
will generate a public getter namedwaitForTest
. This throws a compile error.(changed, was broken) An element named
test
withwait:true
andpublic:false
will not generate a public getter namedwaitForTest
. This should not throw an error if a user defines a method namedwaitForTest
.Code review notes: This is branched off the formatting PR.
QA notes: Look the JSON PO files in the PR to verify they compile as expected.