search

salesforce / warp-drive

Extremely Fast End-to-End Deep Multi-Agent Reinforcement Learning Framework on a GPU (JMLR 2022)
BSD 3-Clause "New" or "Revised" License
465 stars 78 forks source link

integrate lightning #25

Closed Emerald01 closed 2 years ago

Emerald01 commented 2 years ago

basically following example https://github.com/PyTorchLightning/lightning-bolts/blob/master/pl_bolts/models/rl/ppo_model.py

salesforce-cla[bot] commented 2 years ago

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Tian Lan t***@t***.i***.s***.com. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

sunil-s commented 2 years ago

@Emerald01 @kaushikb11 @tchaton please review the file https://github.com/salesforce/warp-drive/blob/pytorch-lightning-integrate/warp_drive/training/lightning_trainer.py

I added the Lightning compatible APIs line 667 onwards - https://github.com/salesforce/warp-drive/blob/pytorch-lightning-integrate/warp_drive/training/lightning_trainer.py#L667

sunil-s commented 2 years ago

Closing this PR (after addressing comments and rebasing with master), replacing with https://github.com/salesforce/warp-drive/pull/27