search

salesforcecli / github-workflows

reusable shared CI scripts
BSD 3-Clause "New" or "Revised" License
15 stars 8 forks source link

External developer friendly changes #90

Closed iowillhoit closed 7 months ago

iowillhoit commented 8 months ago

[!WARNING] Do not merge yet, additional PRs incoming TODO: Revert ew/external-friendly branch refs

We hard coded our svc-cli-bot username/email in a few spots. Making these workflows not useable to external developers. This PR looks up the username/password based on the Github Token being used. Additional changes are made to take advantage of this lookup.

Example of a Release working on an external plugin: https://github.com/iowillhoit/plugin-workflow-test/actions/runs/7748104245 Example of this working on an internal plugin (using secrets inherit) https://github.com/salesforcecli/testPackageRelease/actions/runs/7759564485/job/21163873201#step:8:27

@W-14809762@

Other PRs: https://github.com/oclif/plugin-plugins/pull/784 https://github.com/salesforcecli/plugin-trust/pull/720 https://github.com/salesforcecli/plugin-template-sf-external/pull/110/ https://github.com/forcedotcom/source-deploy-retrieve/pull/1226 https://github.com/salesforcecli/cli/pull/1456

salesforce-cla[bot] commented 7 months ago

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Eric Willhoit. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.