`yarnInstallWithRetries/action.yml` ignores input `ignore-scripts`

[Jucamola]

The --ignore-scripts flag is always added because expressions evaluate the input as a string, so 'false' is true. It can be fixed just by changing it to ${{ inputs.ignore-scripts == 'true' && '--ignore-scripts' || '' }}

I didn't check, but I think there could be the same problem here, here and here

[iowillhoit]

Hey @Jucamola, thanks for the issue. This was fixed yesterday here: https://github.com/salesforcecli/github-workflows/pull/99

The other workflows you linked to will work as expected because they are Workflows and not Actions. Workflow inputs are able to be typed where Action inputs can only be strings.

Example with the npmPublish workflows:

• sign is a boolean here
• It is used here in the same workflow
• Here is an example where we use the npmPublish workflow and do not pass sign: true
• Here is an execution of that workflow and you can see that the --sign flag is not sent to the sf-release npm:package:release command. Here is a screenshot of the same since GHAs don't make their logs available for very long: