search

salesforcecli / github-workflows

reusable shared CI scripts
BSD 3-Clause "New" or "Revised" License
15 stars 8 forks source link

fix: fix ignore-scripts #99

Closed jayree closed 6 months ago

iowillhoit commented 6 months ago

Hey @jayree, the string fix looks good on the --ignore-scripts input.
Could your revert the version bumps on the external Actions though? We use these same actions in several places and we perform a manual code review before bumping them everywhere. If these are block you, I can create a ticket to prioritize bumping these versions

jayree commented 6 months ago

@iowillhoit done. The version bumps were Node.js 16 related. FYI: It seems that some of the actions used by this repo are no longer actively maintained.

iowillhoit commented 6 months ago

Thanks @jayree, a while ago we did an audit of these actions and replaced ones that were abandoned. I'll get a ticket created to look at these too

iowillhoit commented 6 months ago

@W-15727365@