search

salesking / sepa_king

Ruby gem for creating SEPA XML files
MIT License
150 stars 117 forks source link

Allow empty BIC for pain.001.001.03 credit transfers #65

Closed skateinmars closed 7 years ago

skateinmars commented 7 years ago

Hello,

The pain.001.001.03 format does not require the presence of a CdtrAgt block, so there is no need to make the BIC mandatory for transactions using this format.

I added a test that should cover the 3 credit transfer formats.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 2f52bbbaf80e7b83b61903339f3b3b7301a93489 on skateinmars:optional-pain.001.001.03-transaction-bic into b827e5cf5db24bf3d14f77c891eee62b9473a963 on salesking:master.

ledermann commented 7 years ago

Thank you very much!