search

salesking / sepa_king

Ruby gem for creating SEPA XML files
MIT License
149 stars 118 forks source link

Added PstlAdr to Dbtr #71

Closed magegu closed 6 years ago

magegu commented 6 years ago

hi guys,

I added a feature to set an optional PstlAdr as part of Dbtr in a pain.008.002.02.

Use case: https://eur-lex.europa.eu/legal-content/EN/TXT/?uri=celex%3A32015R0847 In other words: we need to include the debtors business address for direct debits from countries like CH, MC, SM,JE, GG, IM, PM and soon GB. jey, brexit 🙄

I added tests and used the code in our own project to test our real life use case.

Looking forward for feedback on this small PR.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 56774e05e5a4d3cccc70891dcd1ef7e37a013b96 on magegu:master into 62756f741ef9b897b70786dc3df6c3ee7127d402 on salesking:master.

ledermann commented 6 years ago

thanks a lot!

magegu commented 6 years ago

thanks! can you release a new minor version, too?

ledermann commented 6 years ago

Done :tada:

magegu commented 6 years ago

super thanks!