search

salesking / sepa_king

Ruby gem for creating SEPA XML files
MIT License
149 stars 118 forks source link

Add Category Purpose to Credit Transactions #78

Closed fcsonline closed 5 years ago

fcsonline commented 5 years ago

When you add transactions in a SEPA file, you can specify the category purpose for them. Some banks are a bit strict about this field and if is not specified, those files are going to be rejected.

This PR adds support for providing information for category purpose.

Following specification as defined in:

https://www.europeanpaymentscouncil.eu/sites/default/files/kb/file/2017-11/EPC115-06%20SCT%20Interbank%20IG%202017%20V1.1.pdf

More information: http://www.sepaforcorporates.com/sepa-payments/sala-sepa-salary-payments/

Some paragraphs from those references:

In salary payments it is required to declare a code here in order to indicate the purpose of the payment is salary.

When it comes to payments there is nothing more important than payroll. Every company needs to ensure that their payroll process is happening efficiently, securely and on time. Getting your payroll wrong could result in unauthorised staff getting access to confidential salary information and / or payroll payments not getting out in time, potentially resulting in staff refusing to work. With SEPA salary payments it is important to be aware of the ‘SALA’ Category Purpose value in the SEPA XML payment format – this post will outline the key points.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 7a4f1eff2cf1b523c3036fb052babb912d6580c4 on factorialco:master into 1249c948a6f47bc24e5ebcdd1d33d677a7a037ae on salesking:master.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.4%) to 99.578% when pulling f5d295810c880ce3a23f0562869bb68520bbabba on factorialco:master into 1249c948a6f47bc24e5ebcdd1d33d677a7a037ae on salesking:master.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.4%) to 99.578% when pulling f5d295810c880ce3a23f0562869bb68520bbabba on factorialco:master into 1249c948a6f47bc24e5ebcdd1d33d677a7a037ae on salesking:master.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.4%) to 99.578% when pulling f5d295810c880ce3a23f0562869bb68520bbabba on factorialco:master into 1249c948a6f47bc24e5ebcdd1d33d677a7a037ae on salesking:master.

ledermann commented 5 years ago

Thank you very much. Before merging this PR: Could you please fix the decreased test coverage?

fcsonline commented 5 years ago

😕 It failed with no reason for activemodel-3.1.x. Could a rebuild fix this?

fcsonline commented 5 years ago

👌

ledermann commented 5 years ago

Thanks!