search

saleweaver / python-amazon-sp-api

Python wrapper to access the amazon selling partner API
https://python-amazon-sp-api.readthedocs.io/en/latest/
MIT License
518 stars 232 forks source link

fulfillment_inbound get_shipment endpoint fix #1468

Closed montarollc closed 1 month ago

montarollc commented 1 month ago

The get_shipment operation on the fulfillment_inbound API (only available on 2024-03-20 version) has the wrong endpoint in the current release. It is currently calling '/inbound/fba//inboundPlans/{inboundPlanId}' but according to the documentation the correct endpoint is '/inbound/fba//inboundPlans/{inboundPlanId}/shipments/{shipmentId}'.

Here is a pull request that corrects the endpoint. Please let me know if this makes sense and if I can be helpful in any way!

saleweaver commented 1 month ago

Hi, thank you for this!

I think this would break the other versions though, wouldn't it?

montarollc commented 1 month ago

No the older versions don't have get_shipment. The equivalent for v0 would be get_shipments_by_id (which takes a list of shipment_ids) which is still there.

saleweaver commented 1 month ago

Ah got it. Didn't see that. Thanks again!