search

saleyn / erlexec

Execute and control OS processes from Erlang/OTP
https://hexdocs.pm/erlexec/readme.html
Other
541 stars 141 forks source link

erlexec not compiling with OTP 21 rc -1 #108

Closed pobengtsson closed 6 years ago

pobengtsson commented 6 years ago

I have an erlang applicaiton that uses erlexec and when tried to build it https://github.com/erlang/otp/releases/tag/OTP-21.0-rc1 using rebar3 and erlexec 1.7.4, the compilation fails with error message:

erlang:get_stacktrace/0: deprecated; use the new try/catch syntax for retrieving the stack backtrace

Could a fix be as easy as just removing the call to get_stacktrace?

saleyn commented 6 years ago

Since the version 21.0 is not yet officially released, I am hesitant to commit the fix yet, but it would involved ifdef'ing that line based on the distribution version to provide backward compatibility, since the new release contains different syntax for obtaining the stacktrace.

pobengtsson commented 6 years ago

Yes, I can understand your point of view. I'll revert to OTP-20 for the time being. Thanks for making erlexec and sharing it as open source.

pdobacz commented 6 years ago

Can we reopen the issue considering 21 release?

saleyn commented 6 years ago

What is the issue? Backward compatibility was addressed by this PR.

pdobacz commented 6 years ago

ah, my bad, didn't notice that PR. Thank you!