search

saleyn / erlexec

Execute and control OS processes from Erlang/OTP
https://hexdocs.pm/erlexec/readme.html
Other
525 stars 139 forks source link

Refactor select and poll handling #143

Closed chrta closed 3 years ago

chrta commented 3 years ago

This reduces the amount of ifdefs and should improve readability and maintainability. The functionality is not changed here.

I did not benchmark it, but the tests ran successfully.

saleyn commented 3 years ago

@chrta, thank you very much! I wanted to do the same refactoring over the next weekend! :)

chrta commented 3 years ago

Very good :) I also played around with templating CmdInfo, but i did not manage to get it working properly.

saleyn commented 3 years ago

The other thing I wanted to have added is the support for unicode commands. If you have spare cycles, feel free to implement. ;)

chrta commented 3 years ago

Thank you for the opportunity, but i will pass ;)