saleyn / erlexec

Execute and control OS processes from Erlang/OTP
https://hexdocs.pm/erlexec/readme.html
Other
541 stars 141 forks source link

added winsz message to call TIOCSWINSZ on pty master #97

Closed noelbk closed 7 years ago

noelbk commented 7 years ago

I'm using erlexec to run remote terminals, and they need the TIOCSWINSZ ioctl to change the window size.

remote terminals also need a few other things, like setting the TERM environment variable, and that'll be coming up next.

saleyn commented 7 years ago

I am currently on vacation - will review it in a couple of weeks. This patch causes a failure of the test case above. Is it related to the change?

noelbk commented 7 years ago

Hm, worked for me, but let me fix up the unit test. Have a good vacation!

~~ Noel

On Fri, Mar 3, 2017 at 8:55 AM, Serge Aleynikov notifications@github.com wrote:

I am currently on vacation - will review it in a couple of weeks. This patch causes a failure of the test case above. Is it related to the change?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/saleyn/erlexec/pull/97#issuecomment-284008230, or mute the thread https://github.com/notifications/unsubscribe-auth/AEVv_xcXqtBAWAykG7TLhKk80wS6EypJks5riEYRgaJpZM4MQZwB .

saleyn commented 7 years ago

@noelbk: did you work on the fix? The test is still failing.

noelbk commented 7 years ago

Ah, finally got the test passing

saleyn commented 7 years ago

Thank you for your contribution!

noelbk commented 7 years ago

No, thank YOU for your project. There's another patch I use to enable echo for pty connections so I can use them as remote terminals. I'll bundle it up in a bit.

Cheers, ~~ Noel

On Tue, Mar 28, 2017 at 8:35 PM, Serge Aleynikov notifications@github.com wrote:

Thank you for your contribution!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/saleyn/erlexec/pull/97#issuecomment-289972344, or mute the thread https://github.com/notifications/unsubscribe-auth/AEVv_3TSsVuqNYWzcsSYcm7A8Fv8Po-yks5rqdF_gaJpZM4MQZwB .

saleyn commented 7 years ago

It would be helpful if you could add sample use case(s) of the features you added/adding here.