Closed salgo60 closed 3 years ago
The badplatsen/api/feature API has an attribute euType (a boolean flag) that, according to the docs, indicates whether the site is to reported to EU or not (in Swedish "Flagga som anger om badet är ett EU bad eller ej")
table(testLocations$euType)
FALSE TRUE 2155 440
Good catch then the question is
I guess https://dd.eionet.europa.eu/dataelements/99263 states that "Must be a valid bathing water identifier in the "WFDProtectedArea" registry"
Next step: we need to speak with people administrating the Swedish database and understand if we need one or two identifiers in Wikidata for supporting EUbaths and Swedish bath waters with euType = False
I agree, best to stick to established nomenclature...We do have nutsCode for all of them, but the term bathingWaterIdentifier does not exist in the API. There are more test locations/sites then what I mentioned, the import fails for a couple of dozens, probably due to data quality issues.
Not all of the nutsCode has an associated test location profile, for example: https://badplatsen.havochvatten.se/badplatsen/api/testlocationprofile/SE0930861000004814
Do we have a good specification of the NUTScode?
In Wikidata we call it Property:P605 and have a regexp [A-Z]{2}[A-Z0-9]{0,3}
and a formatter URL http://dd.eionet.europa.eu/vocabularyconcept/common/nuts/$1 ==>
@anderselias SE0930861000004814 see https://github.com/salgo60/Svenskabadplatser/issues/33
Update found those 3
We find 439 Swedish bathing waters in https://discomap.eea.europa.eu/Bathingwater/
In API badplatsen/api/feature we have 2686 and in Wikidata we have additional some in this projects > 2700