salilab / imp

The Integrative Modeling Platform
https://integrativemodeling.org
GNU General Public License v3.0
74 stars 30 forks source link

Interchange model and reference set of point #1095

Closed muskaan9jindal closed 6 months ago

muskaan9jindal commented 7 months ago

get_pairwise_rmsd_score IMP::atom Namespace Reference has arguments in order (ref1, ref2, mdl1, mdl2)

It calls function get_rmsd_transforming_first in distance.cpp where the argument order is (transformation, ref2, mdl2)

In the following line, ref2, mdl2 should be interchanged to apply the transformation on the mdl2 and not on the ref2. https://github.com/salilab/imp/blob/b3a5ae88faa4eb06a7dcc4c53fb663a7471f17e1/modules/atom/src/distance.cpp#L65