search

salilab / pmi

Python Modeling Interface
https://integrativemodeling.org/nightly/doc/ref/namespaceIMP_1_1pmi.html
11 stars 11 forks source link

Keep support for stat file v1? #231

Closed saltzberg closed 7 years ago

saltzberg commented 7 years ago

Do we need to keep support for stat file v1 in the new PMI release?

If not, I can remove this as I update ProcessOutput.

benmwebb commented 7 years ago

Yes, please don't break any more PMI stuff for now. I just got it all working! I'll be making a new release in the next week or so.

saltzberg commented 7 years ago

Duly noted =)

benmwebb commented 7 years ago

Also, of course, we try not to simply remove stuff. It should be deprecated for one stable release and removed in the next (and noted in the changelog). Removing stuff without telling people is super annoying!

I'll see if I can slip a deprecation warning for old statfiles in before the upcoming release.

saltzberg commented 7 years ago

Sure thing. I could add a deprecation warning into the IF statement that flags a file as stat1. That would be if I knew how to add a deprecation warning, which I don't.

On Wed, Apr 5, 2017 at 10:46 AM, Ben Webb notifications@github.com wrote:

Also, of course, we try not to simply remove stuff. It should be deprecated for one stable release and removed in the next (and noted in the changelog). Removing stuff without telling people is super annoying!

I'll see if I can slip a deprecation warning for old statfiles in before the upcoming release.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/salilab/pmi/issues/231#issuecomment-291940852, or mute the thread https://github.com/notifications/unsubscribe-auth/AG7mwI1qXnK4oMvkCIZBCoLCr-vcu0aLks5rs9NYgaJpZM4M0d8h .

--

Daniel Saltzberg Post-doctoral Scholar University of California at San Francisco Lab of Andrej Sali (www.salilab.org)

T: 415.514.4258

Mailing Address: UCSF MC 2552, Mission Bay, Byers Hall 1700 4th Street, Suite 503B San Francisco, CA 94158-2330

saltzberg@salilab.org ds229@bu.edu

benmwebb commented 7 years ago

The 'official' deprecation macros are only for functions and classes, so for a deprecated file format, just print a warning message. For Python code, here's an example (this is for old-style topology files). For C++ code, use IMP_WARN.