salim-lachdhaf / dropdown_search

Simple and robust Dropdown with item search feature, making it possible to use an offline item list or filtering URL for easy customization.
MIT License
346 stars 334 forks source link

Ripple is affecting errorText and helperText, looks horrible with BorderRadius #700

Open Sinaloense opened 1 month ago

Sinaloense commented 1 month ago

Describe the bug Ripple is affecting errorText and helperText, looks horrible with BorderRadius

To Reproduce Steps to reproduce the behavior:

  1. Embed DropdownSearch with Material
  2. Add borderRadius to clickProps
  3. Add text to labelText or errorText
    return Material(
      child: DropdownSearch<String>(
        items: (filter, infiniteScrollProps) => ['hello', 'world'],
        clickProps: ClickProps(
          borderRadius: BorderRadius.circular(20.00),
        ),
        decoratorProps: DropDownDecoratorProps(
          decoration: InputDecoration(
            labelText: "Sucursal",
            helperText: 'Busque y seleccione la sucursal',
            // errorText: 'Error',
            border: OutlineInputBorder(
              borderRadius: BorderRadius.circular(20.00),
            ),
          ),
        ),
      ),
    );

Expected behavior Add an option to disable ripple effect to labelText and errorText.

Screenshots flutter_pos_tFnGviksBG flutter_pos_Li8vPW9OAp

I dont know if this issue is related with: https://github.com/salim-lachdhaf/dropdown_search/pull/660

dropdown_search: ^6.0.1

salim-lachdhaf commented 1 month ago

Sadly it's a known issue https://github.com/flutter/flutter/issues/106659

Sinaloense commented 1 month ago

Okay, thanks, so we need to wait until fix come directly in DropdownButton

salim-lachdhaf commented 1 month ago

The only solution to the issue is to rewrite the inputDecorator and make it clickable from inside , not as child of inkWell.