search

salimane / rediscluster-py

a Python interface to a Cluster of Redis key-value store
MIT License
47 stars 17 forks source link

Redis Cluster Spec compliance #7

Closed CloudMarc closed 8 years ago

CloudMarc commented 8 years ago

Redis server 3.0 supports clustering.

This code does not comply with the redis cluster spec - http://redis.io/topics/cluster-spec

In particular, it does not handle MOVED and ASK - https://github.com/salimane/rediscluster-py/search?utf8=%E2%9C%93&q=moved&type=Code

cc @antirez

salimane commented 8 years ago

@CloudMarc this library was built before the release of redis 3, thus not supporting the new apis. I would definitely welcome a PR to comply to the redis cluster spec. Thanks

CloudMarc commented 8 years ago

Hi @salimane - I think the point I was trying to make is that people will be confused when they find this and attempt to use it with Redis Cluster. Perhaps there could be a note at the front of the Readme saying this predates Redis Cluster and does not yet support the Redis Cluster Protocol. Also, it's my second invitation to build client-side Redis Cluster support today ;) Cheers

salimane commented 8 years ago

@CloudMarc I fully support your point and a PR for the readme would also be appreciated :)