search

salimkanoun / moodle-mod_dicomviewer

GNU General Public License v3.0
0 stars 3 forks source link

consider adding github actions support for checking code compliance #8

Closed danmarsden closed 3 years ago

danmarsden commented 3 years ago

when you have resolved #6

Some of the tests run by the Moodle.org plugins db can be run via github actions on each commit in your github repo. Enabling this helps you to make sure future changes to your plugin will continue to follow the guidelines.

the short version - grab this file: https://github.com/moodlehq/moodle-plugin-ci/blob/master/gha.dist.yml rename it as ci.yml and put into the directory .github/workflows within tyour project eg: https://github.com/danmarsden/moodle-mod_attendance/blob/main/.github/workflows/ci.yml

then on every commit you make to github it will fire off a request to run the tests and will give you traffic lights beside each commit and generate a report.

danmarsden commented 3 years ago

note - make sure you've got the thirdpartylibs.xml file in there first too, because it will ignore the 3rd party external libs when running these tests.

exploff commented 3 years ago

Thank you for your feedback, we have modified the various problems as well as added the CI. Hoping not to have forgotten anything. We added and validated the CI. Hoping not to have forgotten anything.