search

salimoha / googlecl

Automatically exported from code.google.com/p/googlecl
0 stars 0 forks source link

Google Finance support #295

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What is the enhancement?
Google Finance support.

Please, look at the patch attached. It's just a draft, no implementation is 
done yet. I'm posting it here mainly for people's feedback regarding design of 
the service.
I'll be adding more patches with implementation soon.

Original issue reported on code.google.com by bart...@gmail.com on 24 Sep 2010 at 12:21

Attachments:

GoogleCodeExporter commented 9 years ago 
Implemented portfolio functionality

Original comment by bart...@gmail.com on 24 Sep 2010 at 2:40

Attachments:

GoogleCodeExporter commented 9 years ago 
Implemented positions functionality

Original comment by bart...@gmail.com on 24 Sep 2010 at 11:12

Attachments:

GoogleCodeExporter commented 9 years ago 
Implemented transactions functionality

Original comment by bart...@gmail.com on 25 Sep 2010 at 7:56

Attachments:

GoogleCodeExporter commented 9 years ago 
Final set of changes. Rebased against the latest svn trunk. 
Please, review.

Original comment by bart...@gmail.com on 25 Sep 2010 at 9:18

Attachments:

GoogleCodeExporter commented 9 years ago 
Just to be clear, I should be applying these patches in order of appearance 
onto r431?

Original comment by tom.h.mi...@gmail.com on 26 Sep 2010 at 5:02

GoogleCodeExporter commented 9 years ago 
Exactly.

Original comment by bart...@gmail.com on 26 Sep 2010 at 7:20

GoogleCodeExporter commented 9 years ago 
One more thing.
This change:
@@ -39,7 +40,7 @@ setup(name="googlecl",
       license="Apache Software License",
       packages=packages,
       package_dir={'googlecl':'src/googlecl'},
-      scripts=["src/google"],
+      scripts=["src/google.py"],
       install_requires=['gdata >=1.2.4'],
       long_description=long_desc,
       classifiers=[

in the first patch is not related to finance support. It fixes installation 
bug. I'm not sure I fixed this right way. Revert if you don't like it.

The rest of changes are finance related.

Original comment by bart...@gmail.com on 26 Sep 2010 at 7:32

GoogleCodeExporter commented 9 years ago 
Could you upload the total, merged patch to codereview.appspot.com? It should 
make the review process easier.

Sorry I've been slow getting to this. I'm really excited about it, though :)

Original comment by thmil...@google.com on 4 Oct 2010 at 5:27

GoogleCodeExporter commented 9 years ago 
No problem. Take your time :)

I've uploaded the whole thing for review. You can find it here: 
http://codereview.appspot.com/2357042/

Original comment by bart...@gmail.com on 5 Oct 2010 at 7:59

GoogleCodeExporter commented 9 years ago 
Reformatted output and re-uploaded patch again: 
http://codereview.appspot.com/2412041/
Please, review & apply.

Original comment by bart...@gmail.com on 9 Oct 2010 at 12:13

GoogleCodeExporter commented 9 years ago 
Finance was added at r470. Thanks again, bartosh!

Original comment by thmil...@google.com on 2 Nov 2010 at 12:12