mfbx9da4
commented
3 years ago @saljam I've realized that the reason you need 3 deferred promises is so that the caller code for configuring the peerConnection is evaluated before the offer is created. Using a promise as a synchronization primitive seems a little off here because the caller configuration code is synchronous. I've created three ways of removing the need for the third intermediary promise.
https://codesandbox.io/s/wait-for-caller-promise-zt7y9?file=/src/App.js:1331-1384
Each has its trade-offs. I feel classic callback is the nicest because it is the easiest to understand and the least code. Very close second wait for caller flush event loop. The main benefit of removing the third promise is that the wormhole code is less coupled to the caller code. It doesn't require finish() to be called to march on creating the offer.
The client code would then become something like
const setuppeercon = (pc) => { pc.createDataChannel('....') ... etc }
const w = new Wormhole(url, code, setuppeercon)
const signal = await w.signal()
const fingerprint = await w.finish()That said, your code works, so if it ain't broke, why fix it.
saljam
@saljam this seems to be more or less working. I've tested bad code and establishing a connection. File sending almost works. The file is received, displayed and downloaded but just hangs on the download part. Probably an issue with triggering the download, maybe it has to do with lack of https on localhost? I checked master and it has the same behaviour as this branch. Perhaps I am missing something or master is broken? Can dig in another time to find the root cause.