search

saljam / webwormhole

Peer authenticated WebRTC.
BSD 3-Clause "New" or "Revised" License
1.82k stars 92 forks source link

allow clients to select slot #9

Open saljam opened 4 years ago

saljam commented 4 years ago

The original implementation allowed the client to select an arbitrary slot. The signalling server still supports that.

That worked by optimistically assuming we're side A, sending the PAKE A message and if the slot is already taken throw that away and start again as B.

The uncertainty about which side a client is made me nervous and I never needed to pick my slot anyway, so I disabled this. I'm leaving this issue open to remind myself that if needed this can be brought back.

saljam commented 4 years ago

Some more thoughts on this: we could allow clients to choose their own slots if they're over a certain length. Say 16 bytes, the length of a GUID.

If we then allow more than 2 peers on these long slots (by broadcasting each message to everyone else) this might facilitate using WebWormhole to establish generic multi-party webrtc connections.

saljam commented 4 years ago

this might be a prerequisite for #14