search

sallam-ahmed / Polynomial-Calculator

Data Structure 2015 Course Project
Apache License 2.0
0 stars 3 forks source link

Fixes / UX Improvements #14

Closed faroukm15 closed 8 years ago

faroukm15 commented 8 years ago

1 - Polynomial Parser Improved (New Algorithm) and Fixed parsing free term and first degree term 2 - Polynomial Renderer Improved 3 - Added Polynomial Division (Fully Working) 4 - Added Polynomial Division Reminder [Modulus](Logic Added - Not added to GUI)

khaledkee commented 8 years ago

@faroukm15 In MainForm.cs, in LogInHistory, you don't have a case for OperationTypeEnum.Modulus, which means the _historyTrie will not store the Modulus operations. Is that on purpose?! There is also, I suppose, unnecessary empty method called _BtnDivClick. It may have been, presumably, created by the designer. Consider removing it!

sallam-ahmed commented 8 years ago

@faroukm15 I'll check the parser new algorithm as it manipulates the input value and might fall for signed numbers ( +,-)

faroukm15 commented 8 years ago

@Ahmed-YehiaGPEL about expr = expr.Replace("+X", "1X");, just make it expr = expr.Replace("+X", "+1X"); it will fix the problem.

sallam-ahmed commented 8 years ago

Review

14 Input string not valid when inputting no coefficient , must be auto calculated as 1

Example image

Check MainForm.cs

faroukm15 commented 8 years ago

Added Normally!!

captureadded

khaledkee commented 8 years ago

I'm just wondering: why there is no button for modulus?!

faroukm15 commented 8 years ago

mainForm does not have enough space, so I left it for @Ahmed-YehiaGPEL to find space and add a button.

faroukm15 commented 8 years ago

I'm just wondering, mdy2een awi mn my code leh? :"D

sallam-ahmed commented 8 years ago

Thinking of Improving Main UX Issue #16- Main UX Improvement Will add Modulus in the improvement