Multiple bugs - Githubissues

sallam-ahmed / Polynomial-Calculator

Data Structure 2015 Course Project

Apache License 2.0

0 stars 3 forks source link

Multiple bugs #23

Closed sallam-ahmed closed 8 years ago

sallam-ahmed commented 8 years ago

Multiple bugs aroused while testing:

When multiplying x by 1, the result is stored with a conflict in history Check the image
When dividing x by 1, the result is 1 and stored with the same conflict in history: Check the image _When dividing 1 by x the result is zero.
When multiplying 1 by x, I expected the same result as point 1 but it's not, the parser parses 1 in the first polynomial as x and outputs x^2: Check the image
When subtracting x from 1 it shouldn't output -1x it should output x only, as fixed before but obviously it wasn't handled. Check the image

That's it for now

khaledkee commented 8 years ago

I'm very sorry for this silly bug. I used minimum_rank1 instead of minimum_rank2 in line250. I solved the subtraction bug also. I'm still fixing the history one.

khaledkee commented 8 years ago

About the division one, I can't reproduce this bug. Maybe it was unintentionally solved in the last pull request.

sallam-ahmed commented 8 years ago

@khaledkee it's ok, did you fix the whole bugs in the last pull request ? #22 Bug fixes

khaledkee commented 8 years ago

~~Yes.~~ Note: I couldn't reproduce the division bug. Could you provide a complete log for the bug?! Unfortunately, I didn't save any unit test. If I had saved all unit test, we could have easily run them before each commit to ensure that every single function behaves correctly. I'll try to re-write all unit tests before tomorrow. In the meantime, please test the code exhaustively.

sallam-ahmed commented 8 years ago

I'll test the code until you get the unit tests ready, I'll merge the last pull request then try to reproduce the division bug again.