search

salman-abedin / crystal

Window manager agnostic clear transparent workflow for Unix
GNU General Public License v3.0
27 stars 2 forks source link

Solo/Monocle mode overlapping status bar when coming from Fullscreen #2

Open diogox opened 4 years ago

diogox commented 4 years ago

Hey :wave: First, I'd like to thank you for taking the time to make this and to share it with other people. This is a fantastic script you have here! :smile:

Since shell scripting is not my strong suit, the least I can do is report a few issues I have identified. There were two, but I'll create a different issue for the other one, as it's probably easier for you to manage.

So the first thing I noticed, as you could probably tell from the title, is that when you are in fullscreen mode, and toggle monocle mode (I believe you call it solo in your script), the monocle mode activates, but it overlaps the status bar.

Here's a screenshot: image

This doesn't happen if I toggle fullscreen off first. Only when coming straight from fullscreen to monocle.

Again, thanks for the script. Hope this helps :)

salman-abedin commented 4 years ago

Appreciate the kind words as well as the effort to make the project better. As for the issue at hand, on fullscreen mode, the status bar is not even supposed be there. Please kindly check the Usage section of the README. Used properly, Crystal will hide your status bar on fullscreen mode. Thus, toggling the solo mode while fullscreened will not cause any sort of overlapping of the status bar as there would be no status bar to overlap in the first place. Hopefully you will no longer be having this issue after setting the correct Environment Variable for your status bar.

diogox commented 4 years ago

I had already set the environment variable. And the status bar doesn't show up when in fullscreen mode. It just pops back up when I toggle solo mode. Resulting in what we can see in the image.

salman-abedin commented 4 years ago

I am failing to replicate the issue. I think you're probably using an old version of Crystal where I am certain this was an issue. Try pulling down the repo again and reinstalling.

diogox commented 4 years ago

Still happening :/ I should note, this only happens if you have more than one window in that fullscreened desktop. Anyway, if you can't replicate it, don't worry. It's not a major problem, I can just toggle fullscreen back off and the overlapping goes away :smile:

jakobkukla commented 3 years ago

I have a similar issue. Polybar disappears like intended but if i toggle back to tiled mode, the gap between the polybar and the windows disappears. See the attached gif:

bug

jakobkukla commented 3 years ago

Okay, so i fixed this by adding 20px to the TOPPADDING constant in the script. I don't think this is a very elegant solution though. Can we maybe read out the height of the status bar and set the constant according to it?