search

salman0ansari / whatsapp-api-nodejs

RESTful WhatsApp API with Multiple Device Support
GNU General Public License v3.0
1.27k stars 606 forks source link

Ts conversion #758

Closed Luiz-Monad closed 1 year ago

Luiz-Monad commented 1 year ago

Related to pull request https://github.com/salman0ansari/whatsapp-api-nodejs/pull/486

I was commissioned to create a backend middleware for a frontend using this library, but I cannot use Javascript because its too unproductive, so I ended up doing this task by mistake (figuring out types is literally all fun and games, I did it on my weekend)

I hope nothing got broke as this project has not much in tests.

salman0ansari commented 1 year ago

Nah it's not related to #486 I am rewriting whole project in ts not adding types to existing code.

Adding ts doesn't make any sense to existing code because it's full of bug.

salman0ansari commented 1 year ago

i can push this PR to a different branch but sorry I can't push it to main.

Luiz-Monad commented 1 year ago

I understand this is a breaking change in SemVer. But its a way of removing the bugs. You don't have any tests either, a rewrite is probably required.
That's what forks are for.

This is a temporary solution for me, I'm probably going to rewrite the entire thing in C# as I don't like nodejs that much.

You can leave it in another branch for anyone that might need it for some reason, I only pushed the PR because the license requires me to (its GPL after all).

I wish you the best of luck in your rewrite.