salmannotkhan / typing-test

Typing test website build with React
https://salmannotkhan.github.io/typing-test/
MIT License
189 stars 55 forks source link

Added a theme "Rainbow". #21

Closed i1s-rishabh closed 2 years ago

i1s-rishabh commented 2 years ago

Added a theme "Rainbow".

i1s-rishabh commented 2 years ago

Please don't forget to mention a lable (HACKTOBERFEST-ACCEPTED) with color code (#9c4668) during merge the PR. Thank You in Advance

salmannotkhan commented 2 years ago

Can you please add screenshots with this theme?

i1s-rishabh commented 2 years ago

Can you please add screenshots with this theme?

Sure,

i1s-rishabh commented 2 years ago

Can you please add screenshots with this theme?

typing test

salmannotkhan commented 2 years ago

Can we rename this theme to something that matches the colors?

i1s-rishabh commented 2 years ago

Can we rename this theme to something that matches the colors?

sure

i1s-rishabh commented 2 years ago

sorry, my mistake clicked on close PR ... and I'm changing the name okay

i1s-rishabh commented 2 years ago

changed the theme name rainbow > pink sky

i1s-rishabh commented 2 years ago

And Salman bhai, Please don't forget to mention a lable (HACKTOBERFEST-ACCEPTED) with color code (#9c4668) during merge the PR.

salmannotkhan commented 2 years ago

Is it working? Because in my local it's not. Theme class in themes.scss and theme name in Header.tsx should match

i1s-rishabh commented 2 years ago

Yes, I kept both the name same in theme.scss or header.tsx as a pink-sky

and please change the label what you've used, you should use (HACKTOBERFEST-ACCEPTED) with color code (#9c4668) instead of hacktober-accepted .

salmannotkhan commented 2 years ago

The repository already has the hacktoberfest topic so there is no need for any label here

i1s-rishabh commented 2 years ago

The repository already has the hacktoberfest topic so there is no need for any label here

So, Please go ahead and merge it

salmannotkhan commented 2 years ago

Please fix the conflicts

i1s-rishabh commented 2 years ago

Please fix the conflicts

Fixed! Now check and let me know

salmannotkhan commented 2 years ago

Have are merged properly? If yes can you run prettier on Header.tsx which has lot of spacing issues

salmannotkhan commented 2 years ago

I have merged this as the spacing issue is not from your side

Thank you for your contribution @i1s-rishabh.