Closed i1s-rishabh closed 2 years ago
Please don't forget to mention a lable (HACKTOBERFEST-ACCEPTED) with color code (#9c4668) during merge the PR. Thank You in Advance
Can you please add screenshots with this theme?
Can you please add screenshots with this theme?
Sure,
Can you please add screenshots with this theme?
Can we rename this theme to something that matches the colors?
Can we rename this theme to something that matches the colors?
sure
sorry, my mistake clicked on close PR ... and I'm changing the name okay
changed the theme name rainbow > pink sky
And Salman bhai, Please don't forget to mention a lable (HACKTOBERFEST-ACCEPTED) with color code (#9c4668) during merge the PR.
Is it working? Because in my local it's not. Theme class in themes.scss
and theme name in Header.tsx
should match
Yes, I kept both the name same in theme.scss or header.tsx as a pink-sky
and please change the label what you've used, you should use (HACKTOBERFEST-ACCEPTED) with color code (#9c4668) instead of hacktober-accepted .
The repository already has the hacktoberfest topic so there is no need for any label here
The repository already has the hacktoberfest topic so there is no need for any label here
So, Please go ahead and merge it
Please fix the conflicts
Please fix the conflicts
Fixed! Now check and let me know
Have are merged properly? If yes can you run prettier on Header.tsx
which has lot of spacing issues
I have merged this as the spacing issue is not from your side
Thank you for your contribution @i1s-rishabh.
Added a theme "Rainbow".