salmannotkhan / typing-test

Typing test website build with React
https://salmannotkhan.github.io/typing-test/
MIT License
189 stars 55 forks source link

Added a new restart button #29

Closed sagarkattel closed 2 years ago

sagarkattel commented 2 years ago

There was no restart button while we were taking the test and in the beginning of the test So i tried to add the restart button

Changes i have done:

Installed react icons library -> npm install react-icons --save

Added restart button from react-icons in the Footer.tsx section ->import {VscDebugRestart} from 'react-icons/vsc';

Created span with className as "restart-span" and added a button inside with restart icons from "react-icons"

Make Changes into the Footer.scss file for adding the attributes of newly added span and buttton

sagarkattel commented 2 years ago

restart-button

salmannotkhan commented 2 years ago

I don't think restart button is necessary when you can just press Tab to restart the test.

sagarkattel commented 2 years ago

But after the typing test starts everything is hidden and people won't know how to restart as Footer is also hidden once timer start. Hope you consider that.

salmannotkhan commented 2 years ago

Everything is hidden for a reason. It allows users to focus on the test. monkeytype which is inspiration for this project also follows the same approach

sagarkattel commented 2 years ago

But brother monkeytype also have restart button right?

salmannotkhan commented 2 years ago

It's like that because of personal reason.

sagarkattel commented 2 years ago

Okay bro i understand