Augmentation does not add "fresh" elements to the domain

[thedotmatrix]

When augmenting, we have to add the @element relation for the new elements.

Concrete bug happening from this problem: Facebook example, Query when permission = OnlyMe Augment Read(e^100, e^2) we don't see e^100=e^4 (the new person is equal to the original person)

[thedotmatrix]

@salmans @Element relations are now added to the base and the satIterator. I think the augmentation bug is fixed too. Can you run through the facebook example a couple of times to confirm before we close this?

[salmans]

I think something is broken after the last changes. This is my test-case:

• Run Query 1 of the facebook example
• Augment a model where the permission of the content is Friends with CanRead(e^100, e^5) (e^5 is the content in this model)
• This doesn't add any tuples to relation Friend! I am expecting e^100 to be a friend of the person who shares the post.

If I am not wrong, when we ran this test a few hours ago, the model was correctly augmented with such tuples.

[thedotmatrix]

I believe we used another query. Some remarks:

• The relation is actually Read(e^100,e^5), not CanRead
• Augmenting still doesn't add a friend because no theory rules are fired. The only one that would fire is Read(u1, c) & Post(u2, c) => u1 = u2 | Friend(u1, u2) & permissionOf(c) = 'Friends | Friend(u1, u2) & permissionOf(c) = 'FriendsOfFriends | exists f . Friend(u1, f) & Friend(u2, f) & permissionOf(c) = 'FriendsOfFriends | permissionOf(c) = 'Public;
• Adding Post(u, c) to the Query then augmenting with the CanRead observation makes the original user equivalent to e^100.

Let me know if you agree with these remarks.

[salmans]

My bad! A rule that forces every content to be posted by a user was missing. After I fixed the policy, augmentation is working as it should. I am closing this issue.

Thanks!