search

salomon1184 / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

patch set messages can only be one-liners #267

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Many projects split issues in many small commits.  These can be easily 
represented as patch sets (one per commit in the series).

However, in this case it is impossible to carry a full-blown description for 
each commit.  Having a textarea field available for the patch set would be 
useful.

Original issue reported on code.google.com by paolo.bo...@gmail.com on 27 Jan 2011 at 4:12

GoogleCodeExporter commented 9 years ago 
Actually the intention of patch sets is to represent different (and evolving) 
versions of the same changeset. They can't be easily used for the purpose you 
described. That would break a lot (e.g. how navigation works, the delta between 
patchsets).

I'm closing this as WontFix (let's take this to the mailing list, if I'm too 
quick here).

Original comment by albrecht.andi on 27 Jan 2011 at 7:47

GoogleCodeExporter commented 9 years ago 
Uhm, I knew I shouldn't have mentioned my use case. ;)

I still believe a longer description box can be useful as it ends up in a 
comment.  Sometimes, a single line is not enough to say what changed between 
revisions (for example if you want to reply to many comments at once).  Even if 
you sneak it in the one-line box, the presentation in boldface text is not 
optimal.  Maybe this can be reconsidered even for rietveld's more common 
svn-based usage?

Original comment by paolo.bo...@gmail.com on 28 Jan 2011 at 8:26

GoogleCodeExporter commented 9 years ago 
We've got the "-d/--description" command line flag. I think there's currently 
some misbehavior when updating an issue. IMO the description show up in the web 
interface somewhere and "-m/--message" should be kept as a one-liner. Is it 
that what you're thinking of?

Original comment by albrecht.andi on 28 Jan 2011 at 9:34

GoogleCodeExporter commented 9 years ago 
Maybe the -d is missing in the web interface to add a new patchset then?

Original comment by paolo.bo...@gmail.com on 28 Jan 2011 at 12:12

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 6 Apr 2012 at 7:41