salomonelli / best-resume-ever

:necktie: :briefcase: Build fast :rocket: and easy multiple beautiful resumes and create your best CV ever! Made with Vue and LESS.
https://salomonelli.github.io/best-resume-ever
MIT License
16.32k stars 2.28k forks source link

Exported pdf doesn't reflect styling changes for the material-dark theme #293

Closed zac11 closed 5 years ago

zac11 commented 6 years ago

Case

Issue

I made a couple of changes in the styling for the material-dark theme for my resume. The changes reflect well on the on localhost when I run npm run dev.

However, when the run npm run export the exported excel doesn't reflect the changes in styling due to which the resume right column comes truncated.

Info

Reproduce

Changed the .rightCol {} styling to have

.rightCol {
...
..
.block {
    width:90%;
    position:relative;
    background-color:#ffffff;
    **padding:30px;
    margin-top:15px;
    margin-bottom:15px;**
    display:inline-block;
    box-shadow:0 2px 5px 0 rgba(0,0,0,0.16), 0 2px 10px 0 rgba(0,0,0,0.12);
    .headline {
      font-weight:300;
      display:block;
      font-size:15px;
      color:rgba(0,0,0,0.870588);
    }
swatijadhav commented 5 years ago

Verified this issue and it seems to be working fine. @pubkey We can close this issue as this no longer exists. Thanks

pubkey commented 5 years ago

@swatijadhav thanks for reviewing this. @zac11 I closed this, please reopen or comment if you think this is not resolved.