Consider switching to Electron

[salomvary]

Because:

• The whole apple-xcode-cocoa-objective-c business is #horror and none of my main skills (I usually have no idea what I'm doing in objective-c
• Electron is cross platform
• Electron has a modern browser engine

Inventory list of Electron features needed to port SoundCleod:

• [x] Media keys
• [ ] Headphone play/pause (most likely not supported by Electron, node-hid might be useful)
• [x] Stop on suspend (powerMonitor)
• [x] Custom userAgent
• [x] Window title changed event
• [x] File uploads (does it need to be implemented?)
• [x] Confirm window (does it need to be implemented?)
• [x] Custom dock menu
• [ ] Automatic updates (Squirrel.Mac updates do not seem to be possible to be hosted on GitHub and the entire UI needs to be implemented "by hand". See also https://github.com/Squirrel/Squirrel.Mac/issues/167)

Deal breakers so far: automatic updates.

[joelekstrom]

:scream: But Objective-C is the most beautiful language out there!

[CNLambda]

Objective-C isn't the most beautiful language out there. It's Python (3) and/or Golang. ^^

[davcamer]

Swift?

[CNLambda]

Isn't that bad, but I do like Python a lot more. I think the reason for that is that I started with python, and I can now just create the language constructs other people find so great about their language within python. But it isn't compilable (at least not with the full feature set, as it is a very dynamic), so...

But I would like to have a language having all possibilities like __add__ and so on, that it is headache-free and compilable.

[jbergstroem]

Additional pluses:

• lower barrier of entry for collaborators (javascript)
• webkit -> v8 means we git bug fixes to engines quicker (not sure if that's relevant to Soundcloud, but yeah)
• probably easier to implement configuration for things like injecting stylesheets/greasemonkey for people that wants to modify the experience

Regarding autoupdates and Squirrel, electron suggests nuts -- that should be able to fit on a free heroku (or most other cloud vm's) plan?

[salomvary]

Started playing around with Electron on a branch. First impressions are promising.

[jbergstroem]

That's awesome. I'll check it out after work and see if I can contribute.

[jbergstroem]

@salomvary: not sure why (just yet), but svg2png segfaults for me with soundcleod{-lo}.svg with a segfault (nodejs 6.6.0 on macOS Sierra).

Edit: installed a newer version of phantomjs(-prebuilt) - works fine.

[jbergstroem]

Ok, did a quick sample of both processes. WKWebView and Electron performs similarly; both at <1% cpu when streaming. Measuring stack and active threads Electron seems to perform slightly better, but the difference is negligible. Great job so far! Found a few nits (and CMD + L crashes the view) but I would prefer actually forking and fixing.

Edit: Actually, strike that. Didn't sample long enough. It seems like Electron is more expensive. I'll do some proper testing and report my findings. Regardless, I think moving to Electron is promising.

[salomvary]

So I'm done with porting the basic functionality to Electron. As expected switching to Squirrel updater was the most pain in the ass part...

The release candidate / 1.0.0-beta.1 is available here, I'd appreciate feedback before tagging it final and enabling automatic updates from 0.x: https://github.com/salomvary/soundcleod/releases/tag/v1.0.0-beta.1

[jbergstroem]

@salomvary: tbh it works great for me. I've been running the branch on and off over the week and by looking at your RC notes I feel you have a pretty good insight into what's not working (at the moment). What I haven't tried at all is the updater stuff, nor have I run it in the debugger to see what's going on. I wouldn't call it final (1.0.0) until more feedback lands though. I still haven't had time to dig into sampling but I reckon it's not really needed.

[jbergstroem]

@salomvary perhaps mention the soundcleod helper before prompting for admin permissions?

[salomvary]

Hmm, what exatly promts for admin? Does it happen on install or later? What does the dialog say?

(I'm not seeing it but my setup might be different. I also installed a million times, might only prompt once?)

On 26 Sep 2016, at 15:09, Johan Bergström notifications@github.com wrote:

@salomvary perhaps mention the soundcleod helper before prompting for admin permissions?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[jbergstroem]

it said "Soundcleod wants to install a helper" -- happened when I opened the last packaged version of the electron soundcleod version. Can't find anything useful in console :/

[salomvary]

Ok, I will look into it. Definitely scary (at least without explanation)...

[salomvary]

@jbergstroem where did you run SoundCleod from? Did you copy it to /Applications? Or somewhere else? Or simply from the .dmg file?

[salomvary]

..also, are you maybe running it with a user with no admin rights at all?

[jbergstroem]

Ran it from downloads folder. "Normal" macOS user.

[salomvary]

Fixed in 1.0.0-beta.2 (fb79433effafdfd34b9b9ff6351076154dea204d). The problem was trying to install updates on the read-only file system of the dmg image.

It will still present the same prompt when SoundCleod is installed as admin user but run as non-admin and the non-admin user has no write access to the app. If the admin user can escalate rights to admin, automatic updates will be attempted on every new run of SoundCleod. Handling this properly will require some minimal automatic updater UI where users can temporarily/permanently disable automatic updates.

[salomvary]

1.0.0 is 100% Electron.