salomvary / soundcleod

SoundCloud for macOS and Windows
https://soundcleod.com
MIT License
960 stars 105 forks source link

Frameless? #116

Open jbergstroem opened 8 years ago

jbergstroem commented 8 years ago
screen shot 2016-10-05 at 10 29 16 am

Been playing around with a frameless window and I kind of like it. Just thought I'd check general interest before doing a PR.

Notes:

sammarcus commented 8 years ago

I'd be interested! 🤓

sunmockyang commented 8 years ago

Maybe if we can toggle this option, it'd work well for everyone!

salomvary commented 8 years ago

I'd say 👎 for everything that requires altering how SoundCloud itself behaves inside the window, which includes making things draggable or moving the traffic lights inside.

On the other hand, frameless window looks cool, I'd be up for it if we can make it work considering the above criteria. Is framelessness something that can change while the app is running? Maybe toggle the window header with focus/blur or mouseover mouseout? And whatever we come up with, this should be opt-in (Window menu -> Frameless?)

jbergstroem commented 6 years ago
screen shot 2018-10-10 at 3 24 57 pm

Just an update here. I still have an itch about this because it just looks too damn good. Issues/compromises to address:

  1. When using hiddenInset border window, we probably want to align traffic ligths with the [default] height of the title bar.
  2. soundcloud logo vs traffic lights. Left-pad? In this case, I removed the outer margin for the header container (l-container) to get some more space to play with. The other option could be removing the orange space, but I feel retaining branding is significant. It also touches on @salomvary's (and my own) concern about avoiding modifying the page too much. It's a slippery slope for sure
  3. Dragging. I for now made the titlebar fully dragable meaning a drag would also lead to a click. This is obviously undesirable and the only "clean" areas for dragging would be the space surrounding search and potentially the logo/traffic-lights space. I haven't really dug into this but I can imagine how we would be able to override the click if it follows a drag.

In general it is borderline intrusive which makes me dislike it. But come on. Look at it 💘

Edit: A question worth considering could be implementing our own title bar. It's obviously a step away from being an intentionally stupid browser frame, but there is also opportunity to improve the application experience. Thoughts?

Edit2: I know that Soundcleod and Soundnode intentionally takes two different approaches to this. I just wonder if there is room for "vanilla plus".