saloni-15 / Heel2Toe

A beginner-friendly repository to get started with HTML, CSS, and JS.
https://saloni-15.github.io/Heel2Toe/
MIT License
22 stars 97 forks source link

[Issue] : Fixing navigation bar. #165

Closed zealshah29 closed 2 years ago

zealshah29 commented 2 years ago

Issue Description

Navigation bar present on the home page shows us all the options, but on the other pages, one option is always missing. For example: If I click on "Best seller", "Best Seller" option will disappear from navbar, and this may confuse people. Also we can change the colour of the selected page on the navbar, just to make it user friendly.

Are you a Hacktoberfest'21 contributor

zealshah29 commented 2 years ago

Hello so I would like to contribute to this issue under the Hactoberfest. So may I?

saloni-15 commented 2 years ago

sure @zealshah29, just make sure to reduce the spacing between nav links, as there will be many nav links on the navbar hence can result in cluttering in smaller screens.

zealshah29 commented 2 years ago

Okay, will note that. Thank you!

agamjotsingh18 commented 2 years ago

I can take this issue if not done already?

zealshah29 commented 2 years ago

Hello @saloni-15 , I have made the required changes in the file and followed the steps in git bash as mentioned in the readme file, but when I am trying to make a pull request, I'm getting a message that 'There isn't anything to compare'. Can you please help me out?

saloni-15 commented 2 years ago

You have not pushed your changes to your repository, please push it on your branch and then make a PR.

zealshah29 commented 2 years ago

E74C186B-7884-454A-B6B4-495DCECE44AE I have pushed the file, and it gave me this message, but when I made a PR, it said that there isn’t anything to compare.

saloni-15 commented 2 years ago

you have worked on the navbar branch or you have created the branch after doing the changes?

zealshah29 commented 2 years ago

I have worked on the navbar branch

saloni-15 commented 2 years ago

you must have staged and committed your changes? once check your git status for navbar branch

zealshah29 commented 2 years ago

Yes

zealshah29 commented 2 years ago

So I checked the git status, and it's showing me, "nothing to commit, working tree clean". Shall I clone this project again and make the required changes?

saloni-15 commented 2 years ago

yes