Closed boryn closed 11 months ago
Thanks @boryn!
PS. It's a breaking change between 3.3.0 and 3.3.1. If somebody already defined public bool $useExponentialBackoff
in connector / request it will demand a slight change in the definition to (nullable ?bool
):
public ?bool $useExponentialBackoff
Oh, whoops. Really sorry I didn’t notice that @boryn. I’ll add it to the release notes but it could be considered a hotfix for the recent release.
$useExponentialBackoff
needs to be defined asnull
, as otherwise when$useExponentialBackoff
is only specified at the connector level, this line:$useExponentialBackoff = $request->useExponentialBackoff ?? $this->useExponentialBackoff ?? false;
will evaluate
false
, as it has defaultfalse
value for the request class (inherited fromHasTries
trait)