saloonphp / saloon

🤠 Build beautiful API integrations and SDKs with Saloon
https://docs.saloon.dev
MIT License
2.09k stars 107 forks source link

Feature | Deprecate Auth Methods #368

Closed Sammyjo20 closed 9 months ago

Sammyjo20 commented 9 months ago

This PR deprecates the following methods on the connector/request

I would like to deprecate these methods as they were originally introduced into v1 as a convenient helper method to quickly add auth to an existing connector or request, but I feel that it goes against Saloon’s re-usability pattern.

In my opinion, authentication should always be defined in the defaultAuth method of the connector or request however this auth can still be applied using the authenticate method.