search

salopensource / sal-activedirectory

Apache License 2.0
3 stars 1 forks source link

Discrepancies in documentation #4

Open sheagcraig opened 6 years ago

sheagcraig commented 6 years ago

Hi there- I was giving this a test run and came across a couple of issues.

  1. The AUTH_LDAP_TRUST_ALL_CERTIFICATES is currently mandatory. I had not set it in my settings.py, and the README says that it defaults to False, but then I got an AttributeError during an authentication attempt.
  2. The example_settings file must have an old name for the AD module (ImportError: No module named ADAuthentication). It should be server.ADConnector.ADConnector (which is correctly specified in the README).

I can do up a PR for this if needed.

haribert commented 6 years ago

Thanks for the remarks.

I currently do not have a test environment. Can you please check if the branch 4_documentation_discrepancies (in my fork) solves the mandatory AUTH_LDAP_TRUST_ALL_CERTIFICATES option?