search

salopensource / sal-scripts

Apache License 2.0
23 stars 31 forks source link

Puppet installed from ruby gem has alternative path, facter is not reported to Sal #18

Closed loyaltyarm closed 7 years ago

loyaltyarm commented 7 years ago

When Puppet is installed via sudo gem install puppet, the path specified for the puppet binary is /usr/local/bin/puppet. Similarly, Facter is also installed as part of the ruby gem installation, and is found at /usr/local/bin/facter.

This PR fixes an issue where Sal 3.x does not display Facter menus in the machine detail view due to Facter's path for ruby gem installs not being present in sal-postflight.

Let me know if I got overzealous changing both paths or if they might need to be altered elsewhere.

loyaltyarm commented 7 years ago

@grahamgilbert any thoughts on this?

grahamgilbert commented 7 years ago

I'm on vacation, will respond when I get back.

loyaltyarm commented 7 years ago

any thoughts on this one? it hasn't been a huge priority but closing out related internal stuff

loyaltyarm commented 7 years ago

Thanks! 👍

Sent from my iPhone

On Jun 7, 2017, at 12:20 PM, Graham Gilbert notifications@github.com wrote:

Merged #18.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.