search

salopensource / sal-scripts

Apache License 2.0
23 stars 31 forks source link

improved handling for preflight.d / postflight.d content #38

Closed headmin closed 5 years ago

headmin commented 6 years ago

original source for the PR

https://github.com/zentralopensource/zentral/blob/aa470e4a72c65c55685612409c49c740a97970f1/zentral/contrib/munki/osx_package/build.tmpl/root/usr/local/zentral/munki/preflight

https://github.com/zentralopensource/zentral/blob/aa470e4a72c65c55685612409c49c740a97970f1/zentral/contrib/munki/osx_package/build.tmpl/root/usr/local/zentral/munki/postflight

grahamgilbert commented 6 years ago

Perhaps it would be better to put this error handling in the original function so it covers all script execution?

https://github.com/salopensource/sal-scripts/blob/master/payload/usr/local/sal/utils.py#L232-L241

headmin commented 6 years ago

sure go for it

sheagcraig commented 5 years ago

Looks like @grahamgilbert merged his solution already, so I'll go ahead and close this. Thanks for the submission @headmin!