search

salopensource / sal

Modular reporting for Endpoints
Apache License 2.0
212 stars 64 forks source link

fix: fact_recorded must be set on HistoricalFacts #275

Closed w0de closed 6 years ago

w0de commented 6 years ago

What's on the tin. One line change - when HistoricalFacts are recorded during checkin process, a fact_recorded datetime field must set. Uses django's util for getting the timezone right. Example exception:

IntegrityError: null value in column "fact_recorded" violates not-null constraint
DETAIL:  Failing row contains (944500, memoryfree_mb, 153.63671875, null, 895).
grahamgilbert commented 6 years ago

Fix up your line length and I'll merge

w0de commented 6 years ago

Done. Can I recommend running the whole shebang through black? I use it for my scripts; it's great.