search

salopensource / sal

Modular reporting for Endpoints
Apache License 2.0
212 stars 64 forks source link

Stop building docker image on pull request #309

Open grahamgilbert opened 5 years ago

grahamgilbert commented 5 years ago

Describe the bug Docker builds are attempted on all commits, including pull requests. We shouldn’t build images (or at least we shouldn’t attempt to push them) from sources outside the org.

To Reproduce

  1. Receive pull request
  2. Build fails (due to invalid tag)

Expected behavior Docker build continues (to confirm validity of the build) but does not attempt to push to hub.