search

salopensource / sal

Modular reporting for Endpoints
Apache License 2.0
212 stars 64 forks source link

Managed items feature #315

Closed sheagcraig closed 5 years ago

sheagcraig commented 5 years ago

I figure phase 1 is make sure this model works for everyone. Anyone care to review before I start writing the UI and the checkin v3 code?

grahamgilbert commented 5 years ago

I’m wondering whether we need a changed status? For when puppet, chef or Salt made a change during the run?

sheagcraig commented 5 years ago

Hey @grahamgilbert. So I know that Salt has an actual "Changed" k/v pair in its json output; I was planning on stashing that in the "data" field. I assume other CM will do similar things / have similar output. We could put a dedicated field in; Munki items wouldn't really use it.

I guess we have to balance the ease of access against the generic-ness of the model to apply to all different kinds of "Managed" things.

grahamgilbert commented 5 years ago

Conversely, Munki is unique in that it doesn’t report status of changes it makes. This would mostly be implemented on the client side, but would save having to parse this out on the server side (which is what we’re trying to achieve with this, no?)

grahamgilbert commented 5 years ago

You’re a machine @sheagcraig

sheagcraig commented 5 years ago

The only outstanding work I have to do on this is to add Salt errors/warnings from the logs to the Salt checkin module's messages section. That's not going to impact most people, so this is ready to test!