search

salopensource / sal

Modular reporting for Endpoints
Apache License 2.0
212 stars 64 forks source link

Django Language code error on latest build #375

Closed alexanderolvera closed 4 years ago

alexanderolvera commented 4 years ago

Describe the bug Sal fails to load properly, looking at the debug logs,

SystemCheckError: System check identified some issues:

ERRORS: ?: (translation.E001) You have provided an invalid value for the LANGUAGE_CODE setting.

To Reproduce Steps to reproduce the behavior: Creating new sal container from macadmins/sal:latest

Using an older image, macadmins/sal:cleanup_plugin_code, does not appear to suffer the same bug

I checked a couple of spots I thought might have an issue, system_settings.py LANGUAGE_CODE seems to match between versions

I noticed an environment variable listed in the docker file and tried a few entries with -e DOCKER_SAL_LANG="some lang code here"

but no luck.

First time setting up sal and not very adept at docker so many I am just doing something wrong here. ¯_(ツ)_/¯

nathandarnell commented 4 years ago

I changed the Dockerfile language to en-us and in settings_import.py both mentions of language to LANGUAGE_CODE = 'en-us' and it works. I don't know why just changing it in the Dockerfile didn't fix it but it might be me.

grahamgilbert commented 4 years ago

This is the same problem as https://github.com/grahamgilbert/Crypt-Server/pull/87 I think.

sheagcraig commented 4 years ago

I see some commits in changing the language... Is this solved?

gavinelder commented 4 years ago

Raised https://github.com/salopensource/sal/pull/376 to resolve.