search

salopensource / sal

Modular reporting for Endpoints
Apache License 2.0
214 stars 63 forks source link

New urllib3 dependency conflicts with requests version #426

Closed octomike closed 2 years ago

octomike commented 3 years ago

Describe the bug pip install doesn't work because of conflicting dependencies

To Reproduce

pip install --upgrade -r requirements.txt

Server (please complete the following information):

Additional context

ERROR: Cannot install -r setup/requirements.txt (line 13), requests==2.23.0 and urllib3==1.26.5 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested urllib3==1.26.5
    requests 2.23.0 depends on urllib3!=1.25.0, !=1.25.1, <1.26 and >=1.21.1
    The user requested urllib3==1.26.5
sheagcraig commented 2 years ago

urllib is pinned mostly just to prevent unexpected surprises; same with requests. Both projects have a long history of not breaking things in the API, so this should be pretty safe to just bump to the current release and test. Since this issue is a half year old I'm guessing one of the maintainers should jump in and update everything and validate.

sheagcraig commented 2 years ago

Indeed, this has already been fixed. Huzzah!