search

salopensource / sal

Modular reporting for Endpoints
Apache License 2.0
212 stars 64 forks source link

circle: replace / in CIRCLE_BRANCH to use as docker tag #437

Closed octomike closed 2 years ago

octomike commented 2 years ago

PR jobs are currently failing because CIRCLE_BRANCH contains a /, which is not allowed as a docker tag. Trivial change to replace all occurances of / with _ should "fix" this.

octomike commented 2 years ago

ugh... /bin/sh in docker 18.x does not support this unfortunately

docker run -it --rm docker:19.03.15-git
Unable to find image 'docker:19.03.15-git' locally
19.03.15-git: Pulling from library/docker
540db60ca938: Pull complete 
5a38b3726f4b: Pull complete 
e5fa5deb3340: Pull complete 
09182082685c: Pull complete 
4562e3055ed2: Pull complete 
b4de57a4336a: Pull complete 
542e5df0dc5e: Pull complete 
4d9f7f9542e4: Pull complete 
Digest: sha256:5fbf776b8bb0e431ff612631fb058c5d8d82736d29fedf068d91f7487a2c3587
Status: Downloaded newer image for docker:19.03.15-git
/ # export CIRCLE_BRANCH=pull/1234
/ # echo docker build -t macadmins/sal:${CIRCLE_BRANCH////_}
docker build -t macadmins/sal:pull_1234
octomike commented 2 years ago

escaping seems to have done the trick for that particular version of busybox (and newer)