search

salopensource / sal

Modular reporting for Endpoints
Apache License 2.0
212 stars 64 forks source link

RO Users have no Application Inventory Search menu item at the top level #444

Closed sheagcraig closed 1 year ago

sheagcraig commented 1 year ago

Describe the bug A RO user, when viewing a BU or MG dashboard, has the Application Inventory menu item, but it's missing from the root, "all BUs" view.

To Reproduce Steps to reproduce the behavior:

  1. Create a new user account with RO perms.
  2. Go to the / dashboard.

Expected behavior An Application Inventory menu item.

sheagcraig commented 1 year ago

I have a PR for this incoming.

sheagcraig commented 1 year ago

RO users only have access to BU which they have been granted access to view, so at first it seemed like it would make sense to not have access on the "all" view; however, the inventory app actually filters the queryset based on a user's access, so no gating is required to prevent RO users from seeing this menu item.

Additionally, without this, a RO user has no ability to look at app inventory across an entire Sal instance, only by looking one BU at a time.

AND, if they know the right URL, they can still get to the all inventory view; it's just not in the menu.