search

salopensource / sal

Modular reporting for Endpoints
Apache License 2.0
212 stars 64 forks source link

DiskSpace plugin - 8% or 9% become 80% or 90% in dashboard #459

Closed cristianmaida closed 1 week ago

cristianmaida commented 1 year ago

Describe the bug In DiskSpace plugin Mac with 8% of used disk are in warnign with 80% of used disk MAc with 9% of used disk are in error with 90% of used disk

Screenshot 2023-10-27 alle 11 34 27

Screenshot 2023-10-27 alle 11 34 57

w0de commented 1 year ago

I can't replicate this on latest. Edited device to match shown values as precisely as possible:

Screenshot 2023-10-27 at 12 45 46 PM Screenshot 2023-10-27 at 12 45 30 PM

What Sal version are you using? Is this reproducible with any device in your env, or specific to a subset?

w0de commented 1 year ago

Actually, this is occurring with one (recently wiped) device in our dev instance of Sal. It's notable that this instance is using psql - my local reproduction attempt above is using sqlite.

Suspect this may have something to do with cached querysets.

cristianmaida commented 1 year ago

Latest version of SAL deployed with docker, also latest version of SAL Script. Any Mac device in my env has this bug.

grahamgilbert commented 1 year ago

I have just spot checked about 10-15 devices and they're reporting accurately here. However, we are still on Sal version 4.1.9.

ChefAustin commented 1 year ago

Just came across a device in our production Sal deployment that erroneously fell into the "Machines with more than 90% disk utilization" bucket: image

grahamgilbert commented 1 year ago

I cannot replicate this. Y’all are going to have to do some digging with Postgres and the Django shell to see if you can see where the error is.

On Mon, Oct 30, 2023 at 23:37 Austin Culter @.***> wrote:

Just came across a device in our production Sal deployment that erroneously fell into the "Machines with more than 90% disk utilization" bucket: [image: image] https://user-images.githubusercontent.com/24925402/279279016-780d040b-4e50-4dca-87f4-587bb80a5c80.png

  • Sal scripts v4.8.0
  • Sal v4.1.11.2263 (Docker)
  • Postgres v15.3 (AWS RDS)

— Reply to this email directly, view it on GitHub https://github.com/salopensource/sal/issues/459#issuecomment-1786537005, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJHBLY7SHFGTIVNWXJ227LYCCMA7AVCNFSM6AAAAAA6SQ6AYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBWGUZTOMBQGU . You are receiving this because you commented.Message ID: @.***>