colormatrix filter seg-faults in later versions of FFmbc 0.6-rc4 (second and last versions) and rc5

[GoogleCodeExporter]

ffmbc -i 475_0031_01/475_0031_01.MP4  -vf colormatrix=bt709:bt601 -y out1.mp4
FFmbc version 0.6-rc5
Copyright (c) 2008-2011 Baptiste Coudurier and the FFmpeg developers
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from '475_0031_01/475_0031_01.MP4':
  Metadata:
    major_brand: mp42
    minor_version: 0
    compatible_brands: mp42
    creation_time: 2010-09-30 08:37:58
  Duration: 00:00:30.66, start: 0.000000, bitrate: 36404 kb/s
    Stream #0.0(eng): Video: mpeg2video, yuv420p, 1280x720p [PAR 1:1 DAR 16:9], 35000 kb/s, 50.00 fps
    Stream #0.1(eng): Audio: pcm_s16be, 48000 Hz, 2 channels, s16, 1536 kb/s
[colormatrix @ 0xad8f2d0] bt709 -> bt601
Output #0, mp4, to 'out1.mp4':
  Metadata:
    encoder: FFmbc 0.6
    Stream #0.0(und): Video: mpeg4, yuv420p, 1280x720p [PAR 1:1 DAR 16:9], 200 kb/s, 50.00 fps
    Stream #0.1(und): Audio: libfaac, 48000 Hz, 2 channels, s16, 64 kb/s
Stream mapping:
  Stream #0.0 -> #0.0
  Stream #0.1 -> #0.1
Press [q] to stop encoding
Stream #0.1 dropping frames before start time
adding 960 audio samples in stream #0.1
Segmentation fault

I think the fix is to replace line 377 of vf_colormatrix.c, the last line in 
end_frame(), from this:

avfilter_unref_buffer(out);

to this:

avfilter_unref_buffer(link->cur_buf);

At least - that fixes the issue for me...

Original issue reported on code.google.com by mark.him...@gmail.com on 9 May 2011 at 1:26

[GoogleCodeExporter]

Damn, yes, well spotted, fixed an updated the tarball.

Original comment by baptiste...@gmail.com on 10 May 2011 at 5:39

[GoogleCodeExporter]

Thanks.

Original comment by mark.him...@gmail.com on 10 May 2011 at 2:52

[GoogleCodeExporter]

Original comment by baptiste...@gmail.com on 10 May 2011 at 7:44

• Changed state: Fixed