search

salortiz / NativeHelpers-Blob

Other
7 stars 3 forks source link

MoarVM struct internals change needs following #7

Closed jnthn closed 5 years ago

jnthn commented 5 years ago

MoarVM recently rearranged the layout of the CStruct representation to ease JIT compilation of native calls involving them. Unfortunately, this has broken this module.

The memory layout of representations is not public API, and we're not willing to make it one. In the short term, that means that this module will need to do MoarVM version checks. Beyond that, we should find a way to more properly support the things this module wishes to do, so the functionality it provides is available without depending on implementation details that are subject to change.

salortiz commented 5 years ago

From start I was waiting for this to happen for the amount of trickery involved. I will to review Moar's changes searching for available options. Any recommendations are welcome.

salortiz commented 5 years ago

I commited a naive fix with a version check. All tests passed.