search

salortiz / NativeHelpers-Blob

Other
7 stars 3 forks source link

Correct CStruct repr version check #8

Closed patrickbkr closed 5 years ago

patrickbkr commented 5 years ago

MoarVM 2018.12 did not have the new repr. The next release presumably will. v2018.12 >= v2018.12.*+ returns True and thus NativeHelpers-Blob broke on MoarVM 2018.12. This PR fixes that. I am not entirely sure what the .*+ was intended to do, so I'd be grateful for a second look by whomever merges this request.

salortiz commented 5 years ago

My original commit 189d77e passes all tests with MoarVM 2018.12-110-g04982f6e9 that have the new REPR. @patzim: Can you tell me what exact MoarVM version are you using?

salortiz commented 5 years ago

I´m commited a more specific test that should resolve the ambiguity.

patrickbkr commented 5 years ago

I will test this tomorrow. I used the actual 2018.12 release (so there is no suffix). Thanks for the quick response!

patrickbkr commented 5 years ago

Can you do a version bump? I'm stuck on the previous commit and zef will not update because the version number didn't change. (See https://github.com/ugexe/zef/issues/290#issuecomment-467812784 for an explanation why this happens.)

salortiz commented 5 years ago

Done.